chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js - Issue 2008773002: Begin using ChromeVox Next to read tab and window titles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

Issue 2008773002: Begin using ChromeVox Next to read tab and window titles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bunch of tests. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

index bec050603a1de5b3c5fb81dbf31235aa6e77c7f5..a82292baecbfc92acc99ff1d4e4b509148425ab7 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

@@ -534,8 +534,9 @@ cursors.Range.prototype = {

* @return {boolean}

isWebRange: function() {

- return this.start.node.root.role != RoleType.desktop ||

- this.end.node.root.role != RoleType.desktop;

+ return this.isValid() &&

+ (this.start.node.root.role != RoleType.desktop ||

+ this.end.node.root.role != RoleType.desktop);

/**