Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@1999463002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency from ConsoleMessage to workers. Added test for worker console behavior. BUG=611926 Committed: https://crrev.com/e32ec43a0782851c02153d87cd3d225851d3fe43 Cr-Commit-Position: refs/heads/master@{#395253}

Patch Set 1 #

Total comments: 2

Patch Set 2 : messageN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -114 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/resources/worker-console-worker.js View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html View 1 1 chunk +272 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt View 1 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 3 chunks +25 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 3 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 2 chunks +2 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 4 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 6 chunks +32 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-20 18:17:07 UTC) #2
kozy
lgtm % nit https://codereview.chromium.org/2003433004/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt File third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt (right): https://codereview.chromium.org/2003433004/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt#newcode19 third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt:19: Got console message from worker: worker2 ...
4 years, 7 months ago (2016-05-20 22:30:42 UTC) #3
dgozman
https://codereview.chromium.org/2003433004/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt File third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt (right): https://codereview.chromium.org/2003433004/diff/1/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt#newcode19 third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console-expected.txt:19: Got console message from worker: worker2 On 2016/05/20 22:30:42, ...
4 years, 7 months ago (2016-05-21 04:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003433004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003433004/20001
4 years, 7 months ago (2016-05-21 04:42:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-21 07:06:56 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 07:08:18 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e32ec43a0782851c02153d87cd3d225851d3fe43
Cr-Commit-Position: refs/heads/master@{#395253}

Powered by Google App Engine
This is Rietveld 408576698