Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: messageN Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 404
405 m_session->append(InspectorMemoryAgent::create()); 405 m_session->append(InspectorMemoryAgent::create());
406 406
407 m_session->append(InspectorApplicationCacheAgent::create(m_inspectedFrames.g et())); 407 m_session->append(InspectorApplicationCacheAgent::create(m_inspectedFrames.g et()));
408 408
409 m_session->append(InspectorIndexedDBAgent::create(m_inspectedFrames.get())); 409 m_session->append(InspectorIndexedDBAgent::create(m_inspectedFrames.get()));
410 410
411 InspectorDebuggerAgent* debuggerAgent = new InspectorDebuggerAgent(m_v8Sessi on->debuggerAgent()); 411 InspectorDebuggerAgent* debuggerAgent = new InspectorDebuggerAgent(m_v8Sessi on->debuggerAgent());
412 m_session->append(debuggerAgent); 412 m_session->append(debuggerAgent);
413 413
414 PageConsoleAgent* pageConsoleAgent = new PageConsoleAgent(m_v8Session.get(), m_domAgent, m_inspectedFrames.get()); 414 m_session->append(new PageConsoleAgent(m_v8Session.get(), m_domAgent, m_insp ectedFrames.get()));
415 m_session->append(pageConsoleAgent);
416 415
417 InspectorWorkerAgent* workerAgent = InspectorWorkerAgent::create(m_inspected Frames.get(), pageConsoleAgent); 416 InspectorWorkerAgent* workerAgent = new InspectorWorkerAgent(m_inspectedFram es.get());
418 m_session->append(workerAgent); 417 m_session->append(workerAgent);
419 418
420 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get()); 419 InspectorTracingAgent* tracingAgent = InspectorTracingAgent::create(this, wo rkerAgent, m_inspectedFrames.get());
421 m_tracingAgent = tracingAgent; 420 m_tracingAgent = tracingAgent;
422 m_session->append(tracingAgent); 421 m_session->append(tracingAgent);
423 422
424 m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent, m_v8Ses sion.get())); 423 m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent, m_v8Ses sion.get()));
425 424
426 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get())); 425 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get()));
427 426
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 688 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
690 { 689 {
691 return method == "Debugger.pause" 690 return method == "Debugger.pause"
692 || method == "Debugger.setBreakpoint" 691 || method == "Debugger.setBreakpoint"
693 || method == "Debugger.setBreakpointByUrl" 692 || method == "Debugger.setBreakpointByUrl"
694 || method == "Debugger.removeBreakpoint" 693 || method == "Debugger.removeBreakpoint"
695 || method == "Debugger.setBreakpointsActive"; 694 || method == "Debugger.setBreakpointsActive";
696 } 695 }
697 696
698 } // namespace blink 697 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698