Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: messageN Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
index f1a409fee3a26e6a53aeddfd0977c3f9aaf36d45..7ce7e370ac41cd5fa52029fd3e52cda38685e71e 100644
--- a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
+++ b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
@@ -6,6 +6,7 @@
#define WorkerInspectorProxy_h
#include "core/CoreExport.h"
+#include "core/inspector/ConsoleMessage.h"
#include "core/workers/WorkerThread.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
@@ -30,7 +31,6 @@ public:
public:
virtual ~PageInspector() { }
virtual void dispatchMessageFromWorker(WorkerInspectorProxy*, const String&) = 0;
- virtual void workerConsoleAgentEnabled(WorkerInspectorProxy*) = 0;
};
WorkerThreadStartMode workerStartMode(Document*);
@@ -38,6 +38,7 @@ public:
void workerThreadTerminated();
void dispatchMessageFromWorker(const String&);
void workerConsoleAgentEnabled();
+ void addConsoleMessageFromWorker(ConsoleMessage*);
void connectToInspector(PageInspector*);
void disconnectFromInspector(PageInspector*);
@@ -59,6 +60,8 @@ private:
PageInspector* m_pageInspector;
String m_url;
String m_inspectorId;
+ HeapDeque<Member<ConsoleMessage>> m_consoleMessages;
+ bool m_ignoreConsoleMessages;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698