Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: messageN Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 } 63 }
64 64
65 FrameConsole::FrameConsole(LocalFrame& frame) 65 FrameConsole::FrameConsole(LocalFrame& frame)
66 : m_frame(&frame) 66 : m_frame(&frame)
67 { 67 {
68 } 68 }
69 69
70 void FrameConsole::addMessage(ConsoleMessage* consoleMessage) 70 void FrameConsole::addMessage(ConsoleMessage* consoleMessage)
71 { 71 {
72 if (addMessageToStorage(consoleMessage))
73 reportMessageToClient(consoleMessage);
74 }
75
76 bool FrameConsole::addMessageToStorage(ConsoleMessage* consoleMessage)
77 {
78 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource)
79 return false;
80 if (!m_frame->document() || !messageStorage())
81 return false;
82 messageStorage()->reportMessage(m_frame->document(), consoleMessage);
83 return true;
84 }
85
86 void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
87 {
72 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource) 88 if (muteCount && consoleMessage->source() != ConsoleAPIMessageSource)
73 return; 89 return;
74
75 // FIXME: This should not need to reach for the main-frame.
76 // Inspector code should just take the current frame and know how to walk it self.
77 ExecutionContext* context = frame().document();
78 if (!context)
79 return;
80 if (!messageStorage())
81 return;
82
83 messageStorage()->reportMessage(m_frame->document(), consoleMessage);
84
85 if (consoleMessage->source() == NetworkMessageSource) 90 if (consoleMessage->source() == NetworkMessageSource)
86 return; 91 return;
87 92
88 String stackTrace; 93 String stackTrace;
89 if (consoleMessage->source() == ConsoleAPIMessageSource) { 94 if (consoleMessage->source() == ConsoleAPIMessageSource) {
90 if (!frame().host() || (consoleMessage->scriptArguments() && !consoleMes sage->scriptArguments()->argumentCount())) 95 if (!frame().host() || (consoleMessage->scriptArguments() && !consoleMes sage->scriptArguments()->argumentCount()))
91 return; 96 return;
92 if (!allClientReportingMessageTypes().contains(consoleMessage->type())) 97 if (!allClientReportingMessageTypes().contains(consoleMessage->type()))
93 return; 98 return;
94 if (frame().chromeClient().shouldReportDetailedMessageForSource(frame(), consoleMessage->url())) 99 if (frame().chromeClient().shouldReportDetailedMessageForSource(frame(), consoleMessage->url()))
95 stackTrace = ScriptCallStack::capture()->toString(); 100 stackTrace = ScriptCallStack::capture()->toString();
96 } else { 101 } else {
97 if (consoleMessage->callStack() && frame().chromeClient().shouldReportDe tailedMessageForSource(frame(), consoleMessage->url())) 102 if (consoleMessage->callStack() && frame().chromeClient().shouldReportDe tailedMessageForSource(frame(), consoleMessage->url()))
98 stackTrace = consoleMessage->callStack()->toString(); 103 stackTrace = consoleMessage->callStack()->toString();
99 } 104 }
100 105
101 frame().chromeClient().addMessageToConsole(m_frame, consoleMessage->source() , consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber (), consoleMessage->url(), stackTrace); 106 frame().chromeClient().addMessageToConsole(m_frame, consoleMessage->source() , consoleMessage->level(), consoleMessage->message(), consoleMessage->lineNumber (), consoleMessage->url(), stackTrace);
102 } 107 }
103 108
109 void FrameConsole::reportWorkerMessage(ConsoleMessage* consoleMessage)
110 {
111 reportMessageToClient(consoleMessage);
112 }
113
114 void FrameConsole::adoptWorkerMessage(ConsoleMessage* consoleMessage)
115 {
116 addMessageToStorage(consoleMessage);
117 }
118
104 void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsign ed long requestIdentifier, const ResourceResponse& response) 119 void FrameConsole::reportResourceResponseReceived(DocumentLoader* loader, unsign ed long requestIdentifier, const ResourceResponse& response)
105 { 120 {
106 if (!loader) 121 if (!loader)
107 return; 122 return;
108 if (response.httpStatusCode() < 400) 123 if (response.httpStatusCode() < 400)
109 return; 124 return;
110 if (response.wasFallbackRequiredByServiceWorker()) 125 if (response.wasFallbackRequiredByServiceWorker())
111 return; 126 return;
112 String message = "Failed to load resource: the server responded with a statu s of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusT ext() + ')'; 127 String message = "Failed to load resource: the server responded with a statu s of " + String::number(response.httpStatusCode()) + " (" + response.httpStatusT ext() + ')';
113 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message, response.url().getString(), 0, 0); 128 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message, response.url().getString(), 0, 0);
(...skipping 19 matching lines...) Expand all
133 return &m_frame->host()->consoleMessageStorage(); 148 return &m_frame->host()->consoleMessageStorage();
134 } 149 }
135 150
136 void FrameConsole::clearMessages() 151 void FrameConsole::clearMessages()
137 { 152 {
138 ConsoleMessageStorage* storage = messageStorage(); 153 ConsoleMessageStorage* storage = messageStorage();
139 if (storage) 154 if (storage)
140 storage->clear(m_frame->document()); 155 storage->clear(m_frame->document());
141 } 156 }
142 157
143 void FrameConsole::adoptWorkerMessagesAfterTermination(WorkerInspectorProxy* pro xy)
144 {
145 ConsoleMessageStorage* storage = messageStorage();
146 if (storage)
147 storage->adoptWorkerMessagesAfterTermination(proxy);
148 }
149
150 void FrameConsole::didFailLoading(unsigned long requestIdentifier, const Resourc eError& error) 158 void FrameConsole::didFailLoading(unsigned long requestIdentifier, const Resourc eError& error)
151 { 159 {
152 if (error.isCancellation()) // Report failures only. 160 if (error.isCancellation()) // Report failures only.
153 return; 161 return;
154 ConsoleMessageStorage* storage = messageStorage(); 162 ConsoleMessageStorage* storage = messageStorage();
155 if (!storage) 163 if (!storage)
156 return; 164 return;
157 StringBuilder message; 165 StringBuilder message;
158 message.appendLiteral("Failed to load resource"); 166 message.appendLiteral("Failed to load resource");
159 if (!error.localizedDescription().isEmpty()) { 167 if (!error.localizedDescription().isEmpty()) {
160 message.appendLiteral(": "); 168 message.appendLiteral(": ");
161 message.append(error.localizedDescription()); 169 message.append(error.localizedDescription());
162 } 170 }
163 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message.toString(), error.failingURL(), 0, 0); 171 ConsoleMessage* consoleMessage = ConsoleMessage::create(NetworkMessageSource , ErrorMessageLevel, message.toString(), error.failingURL(), 0, 0);
164 consoleMessage->setRequestIdentifier(requestIdentifier); 172 consoleMessage->setRequestIdentifier(requestIdentifier);
165 storage->reportMessage(m_frame->document(), consoleMessage); 173 storage->reportMessage(m_frame->document(), consoleMessage);
166 } 174 }
167 175
168 DEFINE_TRACE(FrameConsole) 176 DEFINE_TRACE(FrameConsole)
169 { 177 {
170 visitor->trace(m_frame); 178 visitor->trace(m_frame);
171 } 179 }
172 180
173 } // namespace blink 181 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameConsole.h ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698