Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameConsole.h

Issue 2003433004: Remove dependency from ConsoleMessage to workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1999463002
Patch Set: messageN Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 48 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
49 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 49 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
50 class CORE_EXPORT FrameConsole final : public GarbageCollected<FrameConsole> { 50 class CORE_EXPORT FrameConsole final : public GarbageCollected<FrameConsole> {
51 public: 51 public:
52 static FrameConsole* create(LocalFrame& frame) 52 static FrameConsole* create(LocalFrame& frame)
53 { 53 {
54 return new FrameConsole(frame); 54 return new FrameConsole(frame);
55 } 55 }
56 56
57 void addMessage(ConsoleMessage*); 57 void addMessage(ConsoleMessage*);
58 void adoptWorkerMessagesAfterTermination(WorkerInspectorProxy*); 58
59 void reportWorkerMessage(ConsoleMessage*);
60 void adoptWorkerMessage(ConsoleMessage*);
59 61
60 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&); 62 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&);
61 63
62 static void mute(); 64 static void mute();
63 static void unmute(); 65 static void unmute();
64 66
65 void clearMessages(); 67 void clearMessages();
66 68
67 void didFailLoading(unsigned long requestIdentifier, const ResourceError&); 69 void didFailLoading(unsigned long requestIdentifier, const ResourceError&);
68 70
69 DECLARE_TRACE(); 71 DECLARE_TRACE();
70 72
71 private: 73 private:
72 explicit FrameConsole(LocalFrame&); 74 explicit FrameConsole(LocalFrame&);
73 75
74 LocalFrame& frame() const 76 LocalFrame& frame() const
75 { 77 {
76 ASSERT(m_frame); 78 ASSERT(m_frame);
77 return *m_frame; 79 return *m_frame;
78 } 80 }
79 81
80 ConsoleMessageStorage* messageStorage(); 82 ConsoleMessageStorage* messageStorage();
83 bool addMessageToStorage(ConsoleMessage*);
84 void reportMessageToClient(ConsoleMessage*);
81 85
82 Member<LocalFrame> m_frame; 86 Member<LocalFrame> m_frame;
83 }; 87 };
84 88
85 } // namespace blink 89 } // namespace blink
86 90
87 #endif // FrameConsole_h 91 #endif // FrameConsole_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698