Fix URLSearchParams to use the right encoding algorithm

Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst

Committed: https://crrev.com/d165b6b7d3455768f10c9826a54e00937b6f04e9
Cr-Commit-Position: refs/heads/master@{#396801}

[tyoshino (SeeGerritForStatus), 2016-05-19 08:31:37]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 08:31:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998563002/1

[commit-bot: I haz the power, 2016-05-19 10:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 10:15:01]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-05-24 06:48:09]

Description was changed from

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
==========

to

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
==========

[tyoshino (SeeGerritForStatus), 2016-05-24 06:48:09]

tyoshino@chromium.org changed reviewers:
+ sigbjornf@opera.com

[tyoshino (SeeGerritForStatus), 2016-05-24 06:48:58]

+sof

Please note that side-by-side for urlsearchparams-stringifier-expected.txt
doesn't work but it's just deleted.

[sof, 2016-05-24 08:04:37]

lgtm, but my powers don't extend into web/ nor platform/

https://codereview.chromium.org/1998563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/FormDataEncoder.h (right):

https://codereview.chromium.org/1998563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/FormDataEncoder.h:37: enum Mode {
Add a comment to carefully explain what is meant by CRLF here (\n => %0D%0A,
\r[^\n] => %0D%0A) ?

[tyoshino (SeeGerritForStatus), 2016-05-24 08:50:34]

Thanks

https://codereview.chromium.org/1998563002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/FormDataEncoder.h (right):

https://codereview.chromium.org/1998563002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/FormDataEncoder.h:37: enum Mode {
On 2016/05/24 08:04:37, sof wrote:
> Add a comment to carefully explain what is meant by CRLF here (\n => %0D%0A,
> \r[^\n] => %0D%0A) ?

Done.

[tyoshino (SeeGerritForStatus), 2016-05-24 08:52:48]

tyoshino@chromium.org changed reviewers:
+ kinuko@chromium.org, mkwst@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-24 08:53:32]

tyoshino@chromium.org changed reviewers:
+ tkent@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-24 08:53:55]

tyoshino@chromium.org changed reviewers:
- kinuko@chromium.org, tkent@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-24 08:54:30]

+mkwst

Mike, please review modules/credentialmanager/, platform/network and web/

[Mike West, 2016-05-30 11:04:00]

LGTM2! Sorry about the delay on this pretty straightforward review; I was OOO.

[Mike West, 2016-05-30 11:04:17]

On 2016/05/30 at 11:04:00, Mike West (OOO until 30th) wrote:
> LGTM2! Sorry about the delay on this pretty straightforward review; I was OOO.

LGTM too, I mean. Which should give you the magical green bar of happiness.

[tyoshino (SeeGerritForStatus), 2016-05-31 03:37:00]

Description was changed from

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
==========

to

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst
==========

[tyoshino (SeeGerritForStatus), 2016-05-31 04:06:31]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-05-31 04:06:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1998563002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-31 04:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998563002/60001

[commit-bot: I haz the power, 2016-05-31 06:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 06:11:06]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tyoshino (SeeGerritForStatus), 2016-05-31 06:16:07]

The CQ bit was checked by tyoshino@chromium.org

[commit-bot: I haz the power, 2016-05-31 06:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998563002/60001

[commit-bot: I haz the power, 2016-05-31 08:06:46]

Description was changed from

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst
==========

to

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst
==========

[commit-bot: I haz the power, 2016-05-31 08:06:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-31 08:08:20]

Description was changed from

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst
==========

to

==========
Fix URLSearchParams to use the right encoding algorithm

The stringifier of URLSearchParams must use the
application/x-www-form-urlencoded byte serializer algorithm.

The "extract" algorithm of Body mixin defined in the Fetch Standard
should also use the algorithm for processing URLSearchParams.

This algorithm doesn't include CRLF normalization unlike <form>
submission algorithm.

BUG=557063
R=sigbjornf@opera.com,mkwst

Committed: https://crrev.com/d165b6b7d3455768f10c9826a54e00937b6f04e9
Cr-Commit-Position: refs/heads/master@{#396801}
==========

[commit-bot: I haz the power, 2016-05-31 08:08:21]

Patchset 4 (id:??) landed as
https://crrev.com/d165b6b7d3455768f10c9826a54e00937b6f04e9
Cr-Commit-Position: refs/heads/master@{#396801}