Fix URLSearchParams to use the right encoding algorithm

third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 30 matching lines @@
 static inline void append(Vector<char>& buffer, const char* string)
 {
     buffer.append(string, strlen(string));
 }
 
 static inline void append(Vector<char>& buffer, const CString& string)
 {
     buffer.append(string.data(), string.length());
 }
 
+static inline void appendPercentEncoded(Vector<char>& buffer, unsigned char c)
+{
+    append(buffer, '%');
+    appendByteAsHex(c, buffer);
+}
+
 static void appendQuotedString(Vector<char>& buffer, const CString& string)
 {
     // Append a string as a quoted value, escaping quotes and line breaks.
     // FIXME: Is it correct to use percent escaping here? Other browsers do not encode these characters yet,
     // so we should test popular servers to find out if there is an encoding form they can handle.
     size_t length = string.length();
     for (size_t i = 0; i < length; ++i) {
         char c = string.data()[i];
 
         switch (c) {
@@ skipping 109 matching lines @@
 {
     append(buffer, "\r\nContent-Type: ");
     append(buffer, mimeType);
 }
 
 void FormDataEncoder::finishMultiPartHeader(Vector<char>& buffer)
 {
     append(buffer, "\r\n\r\n");
 }
 
-void FormDataEncoder::addKeyValuePairAsFormData(Vector<char>& buffer, const CString& key, const CString& value, EncodedFormData::EncodingType encodingType)
+void FormDataEncoder::addKeyValuePairAsFormData(Vector<char>& buffer, const CString& key, const CString& value, EncodedFormData::EncodingType encodingType, Mode mode)
 {
     if (encodingType == EncodedFormData::TextPlain) {
         if (!buffer.isEmpty())
             append(buffer, "\r\n");
         append(buffer, key);
         append(buffer, '=');
         append(buffer, value);
     } else {
         if (!buffer.isEmpty())
             append(buffer, '&');
-        encodeStringAsFormData(buffer, key);
+        encodeStringAsFormData(buffer, key, mode);
         append(buffer, '=');
-        encodeStringAsFormData(buffer, value);
+        encodeStringAsFormData(buffer, value, mode);
     }
 }
 
-void FormDataEncoder::encodeStringAsFormData(Vector<char>& buffer, const CString& string)
+void FormDataEncoder::encodeStringAsFormData(Vector<char>& buffer, const CString& string, Mode mode)
 {
     // Same safe characters as Netscape for compatibility.
     static const char safeCharacters[] = "-._*";
 
     // http://www.w3.org/TR/html4/interact/forms.html#h-17.13.4.1
     unsigned length = string.length();
     for (unsigned i = 0; i < length; ++i) {
         unsigned char c = string.data()[i];
 
-        if ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || strchr(safeCharacters, c)) {
+        if ((c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c != '\0' && strchr(safeCharacters, c))) {
             append(buffer, c);
         } else if (c == ' ') {
             append(buffer, '+');
-        } else if (c == '\n' || (c == '\r' && (i + 1 >= length || string.data()[i + 1] != '\n'))) {
-            append(buffer, "%0D%0A");
-        } else if (c != '\r') {
-            append(buffer, '%');
-            appendByteAsHex(c, buffer);
+        } else {
+            if (mode == NormalizeCRLF) {
+                if (c == '\n' || (c == '\r' && (i + 1 >= length || string.data()[i + 1] != '\n'))) {
+                    append(buffer, "%0D%0A");
+                } else if (c != '\r') {
+                    appendPercentEncoded(buffer, c);
+                }
+            } else {
+                appendPercentEncoded(buffer, c);
+            }
         }
     }
 }
 
 } // namespace blink