third_party/WebKit/Source/modules/fetch/RequestInit.cpp - Issue 1998563002: Fix URLSearchParams to use the right encoding algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestInit.cpp

Issue 1998563002: Fix URLSearchParams to use the right encoding algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp ('k') | third_party/WebKit/Source/platform/network/FormDataEncoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/RequestInit.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp

index 885686387f0ede148859d55fbb58e50ef32db394..3fcbcbc8ad05fd595bb5c7eef60b17a03f04318f 100644

--- a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp

+++ b/third_party/WebKit/Source/modules/fetch/RequestInit.cpp

@@ -124,7 +124,7 @@ RequestInit::RequestInit(ExecutionContext* context, const Dictionary& options, E

contentType = AtomicString("multipart/form-data; boundary=") + formData->boundary().data();

body = FetchFormDataConsumerHandle::create(context, formData.release());

} else if (V8URLSearchParams::hasInstance(v8Body, isolate)) {

- RefPtr<EncodedFormData> formData = V8URLSearchParams::toImpl(v8::Local<v8::Object>::Cast(v8Body))->encodeFormData();

+ RefPtr<EncodedFormData> formData = V8URLSearchParams::toImpl(v8::Local<v8::Object>::Cast(v8Body))->toEncodedFormData();

contentType = AtomicString("application/x-www-form-urlencoded;charset=UTF-8");

body = FetchFormDataConsumerHandle::create(context, formData.release());

} else if (v8Body->IsString()) {