third_party/WebKit/Source/platform/network/FormDataEncoder.h - Issue 1998563002: Fix URLSearchParams to use the right encoding algorithm

Side by Side Diff: third_party/WebKit/Source/platform/network/FormDataEncoder.h

Issue 1998563002: Fix URLSearchParams to use the right encoding algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reupload Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)	2 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 namespace WTF {	28 namespace WTF {

29 class TextEncoding;	29 class TextEncoding;

30 }	30 }

31	31

32 namespace blink {	32 namespace blink {

33	33

34 class PLATFORM_EXPORT FormDataEncoder {	34 class PLATFORM_EXPORT FormDataEncoder {

35 STATIC_ONLY(FormDataEncoder);	35 STATIC_ONLY(FormDataEncoder);

36 public:	36 public:

	37 enum Mode {
	sof 2016/05/24 08:04:37 Add a comment to carefully explain what is meant b Add a comment to carefully explain what is meant by CRLF here (\n => %0D%0A, \r[^\n] => %0D%0A) ? tyoshino (SeeGerritForStatus) 2016/05/24 08:50:34 Done. Show quoted text On 2016/05/24 08:04:37, sof wrote: > Add a comment to carefully explain what is meant by CRLF here (\n => %0D%0A, > \r[^\n] => %0D%0A) ? Done.
	38 NormalizeCRLF,

	39 DoNotNormalizeCRLF

	40 };

	41

37 static WTF::TextEncoding encodingFromAcceptCharset(const String& acceptChars et, const WTF::TextEncoding& fallbackEncoding);	42 static WTF::TextEncoding encodingFromAcceptCharset(const String& acceptChars et, const WTF::TextEncoding& fallbackEncoding);

38	43

39 // Helper functions used by HTMLFormElement for multi-part form data	44 // Helper functions used by HTMLFormElement for multi-part form data

40 static Vector<char> generateUniqueBoundaryString();	45 static Vector<char> generateUniqueBoundaryString();

41 static void beginMultiPartHeader(Vector<char>&, const CString& boundary, con st CString& name);	46 static void beginMultiPartHeader(Vector<char>&, const CString& boundary, con st CString& name);

42 static void addBoundaryToMultiPartHeader(Vector<char>&, const CString& bound ary, bool isLastBoundary = false);	47 static void addBoundaryToMultiPartHeader(Vector<char>&, const CString& bound ary, bool isLastBoundary = false);

43 static void addFilenameToMultiPartHeader(Vector<char>&, const WTF::TextEncod ing&, const String& filename);	48 static void addFilenameToMultiPartHeader(Vector<char>&, const WTF::TextEncod ing&, const String& filename);

44 static void addContentTypeToMultiPartHeader(Vector<char>&, const CString& mi meType);	49 static void addContentTypeToMultiPartHeader(Vector<char>&, const CString& mi meType);

45 static void finishMultiPartHeader(Vector<char>&);	50 static void finishMultiPartHeader(Vector<char>&);

46	51

47 // Helper functions used by HTMLFormElement for non multi-part form data	52 // Helper functions used by HTMLFormElement for non multi-part form data. Mo de

48 static void addKeyValuePairAsFormData(Vector<char>&, const CString& key, con st CString& value, EncodedFormData::EncodingType = EncodedFormData::FormURLEncod ed);	53 // argument is not used for TextPlain type.

49 static void encodeStringAsFormData(Vector<char>&, const CString&);	54 static void addKeyValuePairAsFormData(Vector<char>&, const CString& key, con st CString& value, EncodedFormData::EncodingType = EncodedFormData::FormURLEncod ed, Mode = NormalizeCRLF);

	55 static void encodeStringAsFormData(Vector<char>&, const CString&, Mode);

50 };	56 };

51	57

52 } // namespace blink	58 } // namespace blink

53	59

54 #endif	60 #endif

OLD	NEW