components/test_runner/web_widget_test_client.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_widget_test_client.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/text_input_controller.cc ('K') | « components/test_runner/text_input_controller.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | content/renderer/browser_plugin/browser_plugin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_widget_test_client.cc

diff --git a/components/test_runner/web_widget_test_client.cc b/components/test_runner/web_widget_test_client.cc

index a3e65061f88931334c3a5ff8716a6efc77346caa..f7d5939f2ffa8d3786f4367d54691364c9eca30a 100644

--- a/components/test_runner/web_widget_test_client.cc

+++ b/components/test_runner/web_widget_test_client.cc

@@ -103,7 +103,7 @@ void WebWidgetTestClient::resetInputMethod() {

// If a composition text exists, then we need to let the browser process

// to cancel the input method's ongoing composition session.

if (web_view_test_proxy_base_)

- web_view_test_proxy_base_->web_widget()->confirmComposition();

+ web_view_test_proxy_base_->web_widget()->confirmComposition(1);

Changwan Ryu 2016/08/03 07:37:29 ditto

yabinh 2016/08/08 07:33:43 Done.

}

} // namespace test_runner