components/test_runner/text_input_controller.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/text_input_controller.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/text_input_controller.cc

diff --git a/components/test_runner/text_input_controller.cc b/components/test_runner/text_input_controller.cc

index cd0aa73b8f394b3e6d7c1649e954ae49c103fd5f..cdbba94774155dfc4a90a281622442569da57959 100644

--- a/components/test_runner/text_input_controller.cc

+++ b/components/test_runner/text_input_controller.cc

@@ -160,11 +160,11 @@ void TextInputController::Install(blink::WebLocalFrame* frame) {

}

void TextInputController::InsertText(const std::string& text) {

- view()->confirmComposition(blink::WebString::fromUTF8(text));

+ view()->confirmComposition(blink::WebString::fromUTF8(text), 1);

}

void TextInputController::UnmarkText() {

- view()->confirmComposition();

+ view()->confirmComposition(1);

Changwan Ryu 2016/08/03 07:37:29 you don't need to pass newCursorPosition when text

yabinh 2016/08/08 07:33:43 Done.

}

void TextInputController::DoCommand(const std::string& text) {

« no previous file with comments | « no previous file | components/test_runner/web_widget_test_client.cc » ('j') | components/test_runner/web_widget_test_client.cc » ('J')