content/renderer/browser_plugin/browser_plugin.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/web_widget_test_client.cc ('K') | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 99092e4ba99f2a870b097f51a661c7778080d6f5..07ccd685172ca4ff96dc6d7bcc3653fed29f0780 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -120,7 +120,8 @@ class CONTENT_EXPORT BrowserPlugin :

int selectionEnd) override;

bool confirmComposition(

const blink::WebString& text,

- blink::WebWidget::ConfirmCompositionBehavior selectionBehavior) override;

+ blink::WebWidget::ConfirmCompositionBehavior selectionBehavior,

Changwan Ryu 2016/08/03 07:37:30 selection_behavior

yabinh 2016/08/08 07:33:43 Done.

+ int newCursorPosition) override;

Changwan Ryu 2016/08/03 07:37:30 new_cursor_position

yabinh 2016/08/08 07:33:43 Done.

void extendSelectionAndDelete(int before, int after) override;

// MouseLockDispatcher::LockTarget implementation.