components/test_runner/web_widget_test_client.cc - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/test_runner/web_widget_test_client.cc

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/test_runner/text_input_controller.cc ('K') | « components/test_runner/text_input_controller.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | content/renderer/browser_plugin/browser_plugin.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/test_runner/web_widget_test_client.h"	5 #include "components/test_runner/web_widget_test_client.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96	96

97 void WebWidgetTestClient::setToolTipText(const blink::WebString& text,	97 void WebWidgetTestClient::setToolTipText(const blink::WebString& text,

98 blink::WebTextDirection direction) {	98 blink::WebTextDirection direction) {

99 test_runner_->setToolTipText(text);	99 test_runner_->setToolTipText(text);

100 }	100 }

101	101

102 void WebWidgetTestClient::resetInputMethod() {	102 void WebWidgetTestClient::resetInputMethod() {

103 // If a composition text exists, then we need to let the browser process	103 // If a composition text exists, then we need to let the browser process

104 // to cancel the input method's ongoing composition session.	104 // to cancel the input method's ongoing composition session.

105 if (web_view_test_proxy_base_)	105 if (web_view_test_proxy_base_)

106 web_view_test_proxy_base_->web_widget()->confirmComposition();	106 web_view_test_proxy_base_->web_widget()->confirmComposition(1);
	Changwan Ryu 2016/08/03 07:37:29 ditto ditto yabinh 2016/08/08 07:33:43 Done. Show quoted text On 2016/08/03 07:37:29, Changwan Ryu wrote: > ditto Done.
107 }	107 }

108	108

109 } // namespace test_runner	109 } // namespace test_runner

OLD	NEW