content/browser/browser_plugin/browser_plugin_guest.h - Issue 1995333002: Handle newCursorPosition correctly for Android's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust selection in confirmCompositionOrInsertText() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/web_widget_test_client.cc ('K') | « components/test_runner/web_widget_test_client.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | content/renderer/browser_plugin/browser_plugin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index ccfb0b990d3b2ee748ae053495a6f266f796ef71..911ea9ab379789ad31dfbfb0d9fa68912ffaa15c 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -339,10 +339,10 @@ class CONTENT_EXPORT BrowserPluginGuest : public GuestHost,

const std::vector<blink::WebCompositionUnderline>& underlines,

int selection_start,

int selection_end);

- void OnImeConfirmComposition(

- int instance_id,

- const std::string& text,

- bool keep_selection);

+ void OnImeConfirmComposition(int instance_id,

+ const std::string& text,

+ bool keep_selection,

+ int newCursorPosition);

void OnExtendSelectionAndDelete(int instance_id, int before, int after);

void OnImeCancelComposition();

#if defined(OS_MACOSX) || defined(USE_AURA)