Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_table.js

Issue 1994563002: Remove the use of KeyEvent.keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_table.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_table.js b/ui/file_manager/file_manager/foreground/js/ui/file_table.js
index c55d94dd4df21457307ac62d9e8580d00cf7d648..3ed3a3fac911da998065540b5a06a086af7f3c3d 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_table.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_table.js
@@ -1234,7 +1234,7 @@ filelist.handleKeyDown = function(e) {
if (e.keyCode == SPACE_KEY_CODE)
return;
// Protect all but the most basic navigation commands in anything else.
- } else if (e.keyIdentifier != 'Up' && e.keyIdentifier != 'Down') {
+ } else if (e.key != 'ArrowUp' && e.key != 'ArrowDown') {
return;
}
}
@@ -1274,28 +1274,28 @@ filelist.handleKeyDown = function(e) {
}
}
- switch (e.keyIdentifier) {
+ switch (e.key) {
case 'Home':
newIndex = this.getFirstIndex();
break;
case 'End':
newIndex = this.getLastIndex();
break;
- case 'Up':
+ case 'ArrowUp':
newIndex = leadIndex == -1 ?
this.getLastIndex() : this.getIndexAbove(leadIndex);
break;
- case 'Down':
+ case 'ArrowDown':
newIndex = leadIndex == -1 ?
this.getFirstIndex() : this.getIndexBelow(leadIndex);
break;
- case 'Left':
- case 'MediaPreviousTrack':
+ case 'ArrowLeft':
+ case 'MediaTrackPrevious':
newIndex = leadIndex == -1 ?
this.getLastIndex() : this.getIndexBefore(leadIndex);
break;
- case 'Right':
- case 'MediaNextTrack':
+ case 'ArrowRight':
+ case 'MediaTrackNext':
newIndex = leadIndex == -1 ?
this.getFirstIndex() : this.getIndexAfter(leadIndex);
break;

Powered by Google App Engine
This is Rietveld 408576698