ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js - Issue 1994563002: Remove the use of KeyEvent.keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js

Issue 1994563002: Remove the use of KeyEvent.keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/file_manager/file_manager/background/js/test_util.js ('K') | « ui/file_manager/file_manager/background/js/test_util.js ('k') | ui/file_manager/file_manager/foreground/js/import_controller.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js b/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js

index b46b7d15f1b54eda88c7b08ebacbee2aa82a0bee..3968879cfa210c133b580e3f7552a62dfda86619 100644

--- a/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js

@@ -190,8 +190,8 @@ DirectoryTreeNamingController.prototype.detach_ = function() {

DirectoryTreeNamingController.prototype.onKeyDown_ = function(event) {

event.stopPropagation();

- switch (util.getKeyModifiers(event) + event.keyIdentifier) {

- case 'U+001B': // Escape

+ switch (util.getKeyModifiers(event) + event.key) {

+ case 'Escape':

this.cancelRename_();

event.preventDefault();

break;