Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ui/file_manager/file_manager/foreground/js/main_window_component.js

Issue 1994563002: Remove the use of KeyEvent.keyIdentifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/main_window_component.js
diff --git a/ui/file_manager/file_manager/foreground/js/main_window_component.js b/ui/file_manager/file_manager/foreground/js/main_window_component.js
index 12c83cadedc4c7e4fc51bba12f4d25ee663cd95c..8c5576b39fa4c45aecc0fe8ea37d450b188954be 100644
--- a/ui/file_manager/file_manager/foreground/js/main_window_component.js
+++ b/ui/file_manager/file_manager/foreground/js/main_window_component.js
@@ -276,9 +276,9 @@ MainWindowComponent.prototype.onKeyDown_ = function(event) {
return;
}
- switch (util.getKeyModifiers(event) + event.keyIdentifier) {
- case 'U+001B': // Escape => Cancel dialog.
- case 'Ctrl-U+0057': // Ctrl+W => Cancel dialog.
+ switch (util.getKeyModifiers(event) + event.key) {
+ case 'Escape': // Escape => Cancel dialog.
+ case 'Ctrl-w': // Ctrl+W => Cancel dialog.
if (this.dialogType_ != DialogType.FULL_PAGE) {
// If there is nothing else for ESC to do, then cancel the dialog.
event.preventDefault();
@@ -305,7 +305,7 @@ MainWindowComponent.prototype.onKeyUp_ = function(event) {
*/
MainWindowComponent.prototype.onDirectoryTreeKeyDown_ = function(event) {
// Enter => Change directory or perform default action.
- if (util.getKeyModifiers(event) + event.keyIdentifier === 'Enter') {
+ if (util.getKeyModifiers(event) + event.key === 'Enter') {
var selectedItem = this.ui_.directoryTree.selectedItem;
if (!selectedItem)
return;
@@ -326,8 +326,8 @@ MainWindowComponent.prototype.onDirectoryTreeKeyDown_ = function(event) {
* @private
*/
MainWindowComponent.prototype.onListKeyDown_ = function(event) {
- switch (util.getKeyModifiers(event) + event.keyIdentifier) {
- case 'U+0008': // Backspace => Up one directory.
+ switch (util.getKeyModifiers(event) + event.key) {
+ case 'Backspace': // Backspace => Up one directory.
event.preventDefault();
// TODO(mtomasz): Use Entry.getParent() instead.
var currentEntry = this.directoryModel_.getCurrentDirEntry();

Powered by Google App Engine
This is Rietveld 408576698