Make ApplicationTestBase not use ApplicationImpl.

Make ApplicationTestBase not use ApplicationImpl.

It didn't have much reason to.

This allows us to make ApplicationImpl's Application implementation
private.

My plan:
* Factor out the guts of ApplicationImpl to a new class called
  ApplicationImplBase, which would have a bunch of (possibly pure)
  virtual methods meant to be overridden. (I'd mark methods not meant to
  be overridden as |final|.)
* ApplicationImpl would (temporarily?) remain, implementing these
  methods by calling out to ApplicationDelegate.
* Convert code to just subclassing/implementing ApplicationImplBase,
  instead of ApplicationDelegate (and instantiating that class, instead
  of ApplicationImpl + their delegate).
* Once no one uses ApplicationImpl/ApplicationDelegate anymore, we can
  remove them.

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/d63ebabd63142a3865c0801292a441ee8c38e03b

[vardhan, 2016-05-17 22:39:59]

lgtm

[viettrungluu, 2016-05-17 22:49:54]

Description was changed from

==========
Make ApplicationTestBase not use ApplicationImpl.

It didn't have much reason to.

This allows us to make ApplicationImpl's Application implementation
private.

My plan:
* Factor out the guts of ApplicationImpl to a new class called
  ApplicationImplBase, which would have a bunch of (possibly pure)
  virtual methods meant to be overridden. (I'd mark methods not meant to
  be overridden as |final|.)
* ApplicationImpl would (temporarily?) remain, implementing these
  methods by calling out to ApplicationDelegate.
* Convert code to just subclassing/implementing ApplicationImplBase,
  instead of ApplicationDelegate (and instantiating that class, instead
  of ApplicationImpl + their delegate).
* Once no one uses ApplicationImpl/ApplicationDelegate anymore, we can
  remove them.

R=vardhan@google.com
==========

to

==========
Make ApplicationTestBase not use ApplicationImpl.

It didn't have much reason to.

This allows us to make ApplicationImpl's Application implementation
private.

My plan:
* Factor out the guts of ApplicationImpl to a new class called
  ApplicationImplBase, which would have a bunch of (possibly pure)
  virtual methods meant to be overridden. (I'd mark methods not meant to
  be overridden as |final|.)
* ApplicationImpl would (temporarily?) remain, implementing these
  methods by calling out to ApplicationDelegate.
* Convert code to just subclassing/implementing ApplicationImplBase,
  instead of ApplicationDelegate (and instantiating that class, instead
  of ApplicationImpl + their delegate).
* Once no one uses ApplicationImpl/ApplicationDelegate anymore, we can
  remove them.

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/d63ebabd63142a3865c0801292a...
==========

[viettrungluu, 2016-05-17 22:49:56]

Committed patchset #2 (id:20001) manually as
d63ebabd63142a3865c0801292a441ee8c38e03b (presubmit successful).