Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: services/js/pingpong_apptest.cc

Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: delete ApplicationImpl::WaitForInitialize() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/js/network_apptest.cc ('k') | services/native_support/process_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/pingpong_apptest.cc
diff --git a/services/js/pingpong_apptest.cc b/services/js/pingpong_apptest.cc
index f2fe971652d984101ce16a078726e9b5984048f5..d76e055ac1217ac5cc24db3f08a1ba2baf7378ef 100644
--- a/services/js/pingpong_apptest.cc
+++ b/services/js/pingpong_apptest.cc
@@ -46,8 +46,7 @@ class JSPingPongTest : public test::JSApplicationTestBase {
void SetUp() override {
ApplicationTestBase::SetUp();
const std::string& url = JSAppURL("pingpong.js");
- mojo::ConnectToService(application_impl()->shell(), url,
- GetProxy(&pingpong_service_));
+ mojo::ConnectToService(shell(), url, GetProxy(&pingpong_service_));
PingPongClientPtr client_ptr;
pingpong_client_.Bind(GetProxy(&client_ptr));
pingpong_service_->SetClient(client_ptr.Pass());
@@ -94,8 +93,8 @@ TEST_F(JSPingPongTest, PingTargetURL) {
// pingpong-target.js URL, we provide a connection to its PingPongService.
TEST_F(JSPingPongTest, PingTargetService) {
PingPongServicePtr target;
- mojo::ConnectToService(application_impl()->shell(),
- JSAppURL("pingpong_target.js"), GetProxy(&target));
+ mojo::ConnectToService(shell(), JSAppURL("pingpong_target.js"),
+ GetProxy(&target));
bool returned_value = false;
PingTargetCallback callback(&returned_value);
pingpong_service_->PingTargetService(target.Pass(), 9, callback);
« no previous file with comments | « services/js/network_apptest.cc ('k') | services/native_support/process_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698