services/asset_bundle/asset_bundle_apptest.cc - Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/asset_bundle/asset_bundle_apptest.cc

Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delete ApplicationImpl::WaitForInitialize() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/asset_bundle/asset_bundle_apptest.cc

diff --git a/services/asset_bundle/asset_bundle_apptest.cc b/services/asset_bundle/asset_bundle_apptest.cc

index de2e58b1dd780fee5262317472df36d8b8fb0d3d..4a9cc511cf2461a2380311173da0c9be69afd4fb 100644

--- a/services/asset_bundle/asset_bundle_apptest.cc

+++ b/services/asset_bundle/asset_bundle_apptest.cc

@@ -8,7 +8,6 @@

#include "base/files/scoped_temp_dir.h"

#include "base/run_loop.h"

#include "mojo/data_pipe_utils/data_pipe_utils.h"

-#include "mojo/public/cpp/application/application_impl.h"

#include "mojo/public/cpp/application/application_test_base.h"

#include "mojo/public/cpp/application/connect.h"

#include "mojo/services/asset_bundle/interfaces/asset_bundle.mojom.h"

@@ -23,7 +22,7 @@ class AssetBundleAppTest : public mojo::test::ApplicationTestBase {

void SetUp() override {

mojo::test::ApplicationTestBase::SetUp();

- mojo::ConnectToService(application_impl()->shell(), "mojo:asset_bundle",

+ mojo::ConnectToService(shell(), "mojo:asset_bundle",

GetProxy(&asset_unpacker_));

}