Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: services/js/echo_apptest.cc

Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: delete ApplicationImpl::WaitForInitialize() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/http_server/http_server_apptest.cc ('k') | services/js/network_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/echo_apptest.cc
diff --git a/services/js/echo_apptest.cc b/services/js/echo_apptest.cc
index 9d7f3438db1534cf5ddf12728c367755623cb0cc..17ae847fd2d6d2dc80b0373a74992c045f4de6e5 100644
--- a/services/js/echo_apptest.cc
+++ b/services/js/echo_apptest.cc
@@ -22,8 +22,7 @@ class JSEchoTest : public test::JSApplicationTestBase {
void SetUp() override {
ApplicationTestBase::SetUp();
const std::string& url = JSAppURL("echo.js");
- mojo::ConnectToService(application_impl()->shell(), url,
- GetSynchronousProxy(&echo_service_));
+ mojo::ConnectToService(shell(), url, GetSynchronousProxy(&echo_service_));
}
mojo::SynchronousInterfacePtr<mojo::EchoService> echo_service_;
@@ -42,8 +41,8 @@ class JSServiceProviderEchoTest : public test::JSApplicationTestBase {
void SetUp() override {
ApplicationTestBase::SetUp();
const std::string& url = JSAppURL("echo.js");
- application_impl()->shell()->ConnectToApplication(
- url, GetProxy(&echo_service_provider_), nullptr);
+ shell()->ConnectToApplication(url, GetProxy(&echo_service_provider_),
+ nullptr);
}
mojo::ServiceProviderPtr echo_service_provider_;
« no previous file with comments | « services/http_server/http_server_apptest.cc ('k') | services/js/network_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698