services/notifications/apptests/notifications_apptest.cc - Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/notifications/apptests/notifications_apptest.cc

Issue 1990603002: Make ApplicationTestBase not use ApplicationImpl. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: delete ApplicationImpl::WaitForInitialize() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/notifications/apptests/notifications_apptest.cc

diff --git a/services/notifications/apptests/notifications_apptest.cc b/services/notifications/apptests/notifications_apptest.cc

index dc41dd131b112fbd196ee9f60376d9c487934752..d61fd63e1ea082a68053f44b89f2f04fa3c01712 100644

--- a/services/notifications/apptests/notifications_apptest.cc

+++ b/services/notifications/apptests/notifications_apptest.cc

@@ -4,7 +4,6 @@

#include "base/bind.h"

#include "base/message_loop/message_loop.h"

-#include "mojo/public/cpp/application/application_impl.h"

#include "mojo/public/cpp/application/application_test_base.h"

#include "mojo/public/cpp/application/connect.h"

#include "mojo/public/cpp/bindings/callback.h"

@@ -31,7 +30,7 @@ class NotificationsApplicationTest : public test::ApplicationTestBase,

// ApplicationTestBase:

void SetUp() override {

ApplicationTestBase::SetUp();

- ConnectToService(application_impl()->shell(), "mojo:notifications",

+ ConnectToService(shell(), "mojo:notifications",

GetProxy(&notification_service_));

}