[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}

Committed: https://crrev.com/5f39d8e602fe8f65a1ff586c26c18e484f9999cd
Cr-Commit-Position: refs/heads/master@{#394503}

[sdefresne, 2016-05-17 17:19:28]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-05-17 17:19:29]

Please take a look and send to CQ if LGTY.

[sdefresne, 2016-05-17 17:43:08]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*".

BUG=None
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

BUG=None
==========

[sdefresne, 2016-05-18 09:49:14]

sdefresne@chromium.org changed reviewers:
+ ben@chromium.org, dpranke@google.com
- brettw@chromium.org

[sdefresne, 2016-05-18 09:49:14]

-brettw, +dpranke: swapping reviewer due to vacations :-)

dpranke: Can you please take a look?

ben: You're the only OWNERS of .gn working this week, can you take a look at
that file for OWNERS approval?

[Dirk Pranke, 2016-05-18 15:20:46]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

BUG=None
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None
==========

[Dirk Pranke, 2016-05-18 15:20:59]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2016-05-18 15:21:24]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-18 15:21:25]

lgtm.

tbr'ing brettw@ for the .gn change, since it's trivial and I should probably be
an owner for it anyway.

[Dirk Pranke, 2016-05-18 15:21:33]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-05-18 15:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984353002/20001

[commit-bot: I haz the power, 2016-05-18 15:29:25]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None
==========

[commit-bot: I haz the power, 2016-05-18 15:29:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 15:30:56]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

[commit-bot: I haz the power, 2016-05-18 15:30:57]

Patchset 2 (id:??) landed as
https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}

[Nico, 2016-05-18 17:24:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1988203002/ by thakis@chromium.org.

The reason for reverting is: breaks the cq for everyone (e.g.
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn...).

[sdefresne, 2016-05-18 18:01:46]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

[sdefresne, 2016-05-18 18:12:10]

I've fixed the issue that caused the failure and lead to the revert. Dirk can
you take another look (last patchset is the fix) and send to CQ if LGTY?

[sdefresne, 2016-05-18 18:18:09]

On 2016/05/18 18:12:10, sdefresne wrote:
> I've fixed the issue that caused the failure and lead to the revert. Dirk can
> you take another look (last patchset is the fix) and send to CQ if LGTY?

My comment was referring to patchset #4 (that had not been uploaded then).

[Dirk Pranke, 2016-05-18 19:20:56]

lgtm.

[Dirk Pranke, 2016-05-18 19:21:03]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-05-18 19:21:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984353002/60001

[commit-bot: I haz the power, 2016-05-18 19:27:51]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

[commit-bot: I haz the power, 2016-05-18 19:27:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 19:29:25]

Description was changed from

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}
==========

to

==========
[iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Add missing dependencies, add circular include exception for targets that
are conceptually a single target but split for practical reason, move some
files and remove obsolete includes to fix "gn check".

Enable "gn check" for "//ios/*" and "//ios_internal/*".

R=dpranke@chromium.org
TBR=brettw@chromium.org
BUG=None

Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
Cr-Commit-Position: refs/heads/master@{#394428}

Committed: https://crrev.com/5f39d8e602fe8f65a1ff586c26c18e484f9999cd
Cr-Commit-Position: refs/heads/master@{#394503}
==========

[commit-bot: I haz the power, 2016-05-18 19:29:26]

Patchset 4 (id:??) landed as
https://crrev.com/5f39d8e602fe8f65a1ff586c26c18e484f9999cd
Cr-Commit-Position: refs/heads/master@{#394503}