ios/web/public/app/BUILD.gn - Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/app/BUILD.gn

Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "--check" after https://codereview.chromium.org/1956113002/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/public/app/BUILD.gn

diff --git a/ios/web/public/app/BUILD.gn b/ios/web/public/app/BUILD.gn

index b2e21aa84dc974a306e49f820526030c9f6ee8ba..e55a118d5ebcd48cd4f3ac8aa2c7b0d707b9b06c 100644

--- a/ios/web/public/app/BUILD.gn

+++ b/ios/web/public/app/BUILD.gn

@@ -10,10 +10,12 @@ source_set("app") {

]

public_deps = [

- "//base",

+ "//ios/web/app",

]

deps = [

- "//ios/web/app",

+ "//base",

]

+ allow_circular_includes_from = [ "//ios/web/app" ]

}

« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/shell/BUILD.gn » ('j') | no next file with comments »