ios/chrome/common/app_group/BUILD.gn - Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/common/app_group/BUILD.gn

Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "--check" after https://codereview.chromium.org/1956113002/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/common/app_group/BUILD.gn

diff --git a/ios/chrome/common/app_group/BUILD.gn b/ios/chrome/common/app_group/BUILD.gn

index 8da60efed26bfd746ceb93ce1853fd67c8a537b6..5309f41446384b070da8a553fa6a429493d4f8cf 100644

--- a/ios/chrome/common/app_group/BUILD.gn

+++ b/ios/chrome/common/app_group/BUILD.gn

@@ -31,6 +31,7 @@ source_set("client") {

deps = [

":app_group",

+ "//base",

]

}

@@ -42,5 +43,6 @@ source_set("main_app") {

deps = [

":app_group",

+ "//base",

]

}

« no previous file with comments | « ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc ('k') | ios/chrome/test/BUILD.gn » ('j') | no next file with comments »