ios/chrome/app/strings/BUILD.gn - Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/strings/BUILD.gn

Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "--check" after https://codereview.chromium.org/1956113002/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/app/strings/BUILD.gn

diff --git a/ios/chrome/app/strings/BUILD.gn b/ios/chrome/app/strings/BUILD.gn

index 8797d1a7d4b4c79d3a77d53901ef5bd0839ca610..b6e9a6f7e3c962060e00924b3588ff4ff0c17d51 100644

--- a/ios/chrome/app/strings/BUILD.gn

+++ b/ios/chrome/app/strings/BUILD.gn

@@ -6,7 +6,7 @@ import("//build/config/chrome_build.gni")

import("//tools/grit/grit_rule.gni")

group("strings") {

- deps = [

+ public_deps = [

":ios_chromium_strings",

":ios_google_chrome_strings",

":ios_strings",

« no previous file with comments | « ios/chrome/BUILD.gn ('k') | ios/chrome/browser/BUILD.gn » ('j') | no next file with comments »