ios/web/shell/BUILD.gn - Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/shell/BUILD.gn

Issue 1984353002: [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix "--check" after https://codereview.chromium.org/1956113002/ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/shell/BUILD.gn

diff --git a/ios/web/shell/BUILD.gn b/ios/web/shell/BUILD.gn

index f9f3a6b6f0ba2c66edb52f8c7dd1d6a04c443ac9..2fd2c5d1bfd9d0365a068989edaf582e83342e58 100644

--- a/ios/web/shell/BUILD.gn

+++ b/ios/web/shell/BUILD.gn

@@ -15,6 +15,10 @@ ios_app_bundle("ios_web_shell") {

deps = [

":shell",

+ # All shared libraries must have the sanitizer deps to properly link in

+ # asan mode (this target will be empty in other cases).

+ "//build/config/sanitizers:deps",

]

ldflags = [

@@ -67,15 +71,13 @@ source_set("shell") {

":main_view_bundle_data",

":shell_bundle_data",

"//base",

+ "//ios/net",

"//ios/web",

+ "//ios/web:user_agent",

"//ios/web/public/app",

"//net",

"//net:extras",

"//ui/base",

- # All shared libraries must have the sanitizer deps to properly link in

- # asan mode (this target will be empty in other cases).

- "//build/config/sanitizers:deps",

]

libs = [

« no previous file with comments | « ios/web/public/app/BUILD.gn ('k') | no next file » | no next file with comments »