Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2). (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
jimmacauley1, *tzik
CC:
tzik, ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, Justin Novosad, kinuko+watch, kinuko+fileapi, loading-reviews+fetch_chromium.org, mkwst+watchlist-csp_chromium.org, nhiroki, rwlbuis, sof, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OwnPtr::release() calls in core/ (part 2). OwnPtr::release() calls can be (1) replaced with std::move(), or (2) removed entirely (in certain "return" statements). BUG=611660 Committed: https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad Cr-Commit-Position: refs/heads/master@{#393808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -123 lines) Patch
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 18 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverStats.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DecodedDataDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLToken.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/ResourcePreloader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983753002/1
4 years, 7 months ago (2016-05-16 05:33:31 UTC) #2
Yuta Kitamura
PTAL?
4 years, 7 months ago (2016-05-16 05:44:14 UTC) #6
tzik
lgtm
4 years, 7 months ago (2016-05-16 06:06:07 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 07:16:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983753002/1
4 years, 7 months ago (2016-05-16 07:43:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 07:50:38 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/995cd784dac8a41053410ca3fae7f7b57cd4ebad Cr-Commit-Position: refs/heads/master@{#393808}
4 years, 7 months ago (2016-05-16 07:53:04 UTC) #15
jimmacauley1
4 years, 7 months ago (2016-05-17 20:24:32 UTC) #17
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698