third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp - Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

index 15a5aaf1d36714052c7ccaf8db2548737a75454c..939aa3836a892d4162a09e8d86ce1e8046e7d0b7 100644

--- a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

@@ -222,7 +222,7 @@ void CSSPreloadScanner::emitRule(const SegmentedString& source)

TextPosition position = TextPosition(source.currentLine(), source.currentColumn());

OwnPtr<PreloadRequest> request = PreloadRequest::create(FetchInitiatorTypeNames::css, position, url, *m_predictedBaseElementURL, Resource::CSSStyleSheet, m_referrerPolicy);

// FIXME: Should this be including the charset in the preload request?

- m_requests->append(request.release());

+ m_requests->append(std::move(request));

}

m_state = Initial;

} else if (equalIgnoringCase(m_rule, "charset"))