third_party/WebKit/Source/core/html/forms/FormController.cpp - Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/FormController.cpp

Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/FormController.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/FormController.cpp b/third_party/WebKit/Source/core/html/forms/FormController.cpp

index fecdd45079f42fc87d1d6e64db5cb66ca6b5d001..f9c01cbfea366990b64929b04ce68a4cd31d4da7 100644

--- a/third_party/WebKit/Source/core/html/forms/FormController.cpp

+++ b/third_party/WebKit/Source/core/html/forms/FormController.cpp

@@ -222,7 +222,7 @@ PassOwnPtr<SavedFormState> SavedFormState::deserialize(const Vector<String>& sta

return nullptr;

savedFormState->appendControlState(AtomicString(name), AtomicString(type), state);

}

- return savedFormState.release();

+ return savedFormState;

}

void SavedFormState::serializeTo(Vector<String>& stateVector) const

@@ -493,7 +493,7 @@ void FormController::formStatesFromStateVector(const Vector<String>& stateVector

i = 0;

break;

}

- map.add(formKey, state.release());

+ map.add(formKey, std::move(state));

}

if (i != stateVector.size())

map.clear();