third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp - Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

index 01b52462b2cb4fdd8fa468a035ef476442b0cea4..fe0dfa0e29c5b8739b60e38471ab706d0b99c376 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

@@ -236,7 +236,7 @@ public:

request->setCharset(charset());

request->setDefer(m_defer);

request->setIntegrityMetadata(m_integrityMetadata);

- return request.release();

+ return request;

}

private:

@@ -736,7 +736,7 @@ void TokenPreloadScanner::scanCommon(const Token& token, const SegmentedString&

scanner.handlePictureSourceURL(m_pictureData);

OwnPtr<PreloadRequest> request = scanner.createPreloadRequest(m_predictedBaseElementURL, source, m_clientHintsPreferences, m_pictureData, m_documentParameters->referrerPolicy);

if (request)

- requests.append(request.release());

+ requests.append(std::move(request));

return;

}

default: {