Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp

Issue 1983753002: Remove OwnPtr::release() calls in core/ (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
index 1fb25796842dcb24f07b81683307482d1f685524..f3263eacd39e50d987d6385845b1193a712d8a3d 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
@@ -39,13 +39,13 @@ CSSParserSelector::~CSSParserSelector()
if (!m_tagHistory)
return;
Vector<OwnPtr<CSSParserSelector>, 16> toDelete;
- OwnPtr<CSSParserSelector> selector = m_tagHistory.release();
+ OwnPtr<CSSParserSelector> selector = std::move(m_tagHistory);
while (true) {
- OwnPtr<CSSParserSelector> next = selector->m_tagHistory.release();
- toDelete.append(selector.release());
+ OwnPtr<CSSParserSelector> next = std::move(selector->m_tagHistory);
+ toDelete.append(std::move(selector));
if (!next)
break;
- selector = next.release();
+ selector = std::move(next);
}
}
@@ -92,15 +92,15 @@ void CSSParserSelector::appendTagHistory(CSSSelector::RelationType relation, Pas
PassOwnPtr<CSSParserSelector> CSSParserSelector::releaseTagHistory()
{
setRelation(CSSSelector::SubSelector);
- return m_tagHistory.release();
+ return std::move(m_tagHistory);
}
void CSSParserSelector::prependTagSelector(const QualifiedName& tagQName, bool isImplicit)
{
OwnPtr<CSSParserSelector> second = CSSParserSelector::create();
- second->m_selector = m_selector.release();
- second->m_tagHistory = m_tagHistory.release();
- m_tagHistory = second.release();
+ second->m_selector = std::move(m_selector);
+ second->m_tagHistory = std::move(m_tagHistory);
+ m_tagHistory = std::move(second);
m_selector = adoptPtr(new CSSSelector(tagQName, isImplicit));
}

Powered by Google App Engine
This is Rietveld 408576698