Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1983183002: Landing Recent QUIC changes until 5/14/2016 02:25:25 UTC (Closed)

Created:
4 years, 7 months ago by danzh1
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 5/14/2016 02:25:25 UTC rel-note: Add a QUIC EndToEndTest to have the server close the connection via public reset. n/a (Test only) Merge internal change: 122317778 https://codereview.chromium.org/1984953003/ rel-note: QUIC test-only change. Removes unnecessary mock method. Merge internal change: 122301171 https://codereview.chromium.org/1986313002/ rel-note: Generate QUIC public reset packets with old public flags values, protected by FLAG_quic_use_old_public_reset_packets, enabled by default. Merge internal change: 122225917 https://codereview.chromium.org/1986793002/ rel-note: Consider receiving crypto frames on non crypto stream as memory corruption. Protected by FLAG_quic_detect_memory_corrpution. Merge internal change: 122153221 Add quic_simple_server_stream_test.cc into net.gypi https://codereview.chromium.org/1987523003/ rel-note: Add an additional ReliableQuicStream* argument to QuicSession::WritevData in an attempt to defend against memory corruption that might lead to unencrypted stream data. Merge internal change: 122080193 https://codereview.chromium.org/1989503002/ rel-note: Rename QUIC's kMaxCongestionWindow to kMaxResumptionCongestionWindow and move it into TcpCubicSenderBase. n/a (Constant rename) Merge internal change: 122078733 https://codereview.chromium.org/1988793002/ rel-note: Fix bug in QUIC SCUP message generation in which the client nonce was used in place of the CHLO hash when generating the proof. Merge internal change: 121980704 https://codereview.chromium.org/1986193002/ rel-note: Deprecate quic_always_has_unacked_packets_on_timeout Merge internal change: 121962941 https://codereview.chromium.org/1984243002/ rel-note: Add ActivateStream() to QuicSessionPeer. Merge internal change: 121961869 https://codereview.chromium.org/1988713004/ rel-note: Remove GetRttStats from QuicSentPacketManagerPeer. n/a (test change only). Merge internal change: 121946365 https://codereview.chromium.org/1986183002/ rel-note: Add more information to QUIC close connection detail about QUIC_OVERLAPPING_STREAM_DATA. Merge internal change: 121941143 https://codereview.chromium.org/1979193012/ rel-note: Cancel pending retransmissions which are greater than the largest newly acked packet when using the UNDO connection option. Protected by existing flag FLAG_quic_loss_recovery_use_largest_acked. Merge internal change: 121905158 https://codereview.chromium.org/1982103002/ rel-note: Fix the usage string in the QUIC packet printer n/a - command line tool only Merge internal change: 121845603 https://codereview.chromium.org/1986603002/ rel-note: QUIC_BUG if handshake packets should never send a fin. No functional change intended. Merge internal change: 121840142 https://codereview.chromium.org/1979193011/ rel-note: Add a command line tool for printing QUIC crypto handshake messages. n/a - command line tool only Merge internal change: 121831081 https://codereview.chromium.org/1982823002/ BUG= Committed: https://crrev.com/1401f0a570552fcd9316fbfa15ccfa2bb69d5711 Cr-Commit-Position: refs/heads/master@{#394756}

Patch Set 1 #

Patch Set 2 : first try to fix asan in QuicSimpleServerStreamTest() #

Patch Set 3 : Fix static_assert failed "quic_error_map is not in sync with quic protocol! #

Patch Set 4 : "first try to fix link error for win_clang build" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -244 lines) Patch
M components/domain_reliability/quic_error_mapping.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_packets_test.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 2 chunks +17 lines, -6 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_connection.h View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +33 lines, -7 lines 0 comments Download
M net/quic/quic_connection_test.cc View 11 chunks +47 lines, -10 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +22 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 12 chunks +78 lines, -15 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +28 lines, -33 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer_buffer.cc View 1 chunk +10 lines, -15 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 18 chunks +36 lines, -32 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +7 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A net/tools/quic/crypto_message_printer_bin.cc View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_packet_printer_bin.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_session_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 21 chunks +21 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983183002/20001
4 years, 7 months ago (2016-05-17 19:13:50 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/67809) android_compile_dbg on ...
4 years, 7 months ago (2016-05-17 19:31:01 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983183002/40001
4 years, 7 months ago (2016-05-17 20:14:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/23389)
4 years, 7 months ago (2016-05-17 23:19:42 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983183002/60001
4 years, 7 months ago (2016-05-18 14:39:34 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 15:44:29 UTC) #15
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-19 13:33:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983183002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983183002/60001
4 years, 7 months ago (2016-05-19 13:36:31 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-19 13:41:25 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:42:53 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1401f0a570552fcd9316fbfa15ccfa2bb69d5711
Cr-Commit-Position: refs/heads/master@{#394756}

Powered by Google App Engine
This is Rietveld 408576698