Issue 1982103002: Cancel pending retransmissions which are greater than the largest newly acked packet when using the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1982103002: Cancel pending retransmissions which are greater than the largest newly acked packet when using the… (Closed)

Created:
4 years, 7 months ago by danzh1

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett

Base URL:
https://chromium.googlesource.com/chromium/src.git@121845603

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cancel pending retransmissions which are greater than the largest newly acked packet when using the UNDO connection option. Protected by existing flag quic_loss_recovery_use_largest_acked. Merge internal change: 121905158 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -12 lines)			Patch
M	net/quic/crypto/crypto_protocol.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	5 chunks	+22 lines, -0 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	2 chunks	+68 lines, -0 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1986603002 Patch 1

Dependent Patchsets:

Issue 1979193012 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages