Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1982823002: Add a command line tool for printing QUIC crypto handshake messages. (Closed)

Created:
4 years, 7 months ago by danzh1
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a command line tool for printing QUIC crypto handshake messages. n/a - command line tool only Merge internal change: 121831081 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : include newly added file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M net/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
M net/net.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A net/tools/quic/crypto_message_printer_bin.cc View 1 1 chunk +58 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1954183002 Patch 1

Dependent Patchsets:

Issue 1979193011 Patch 1

Messages

Total messages: 7 (1 generated)
danzh1
4 years, 7 months ago (2016-05-16 21:44:32 UTC) #1
Ryan Hamilton
I don't see crypto_message_printer_bin.cc in this CL?
4 years, 7 months ago (2016-05-16 21:48:11 UTC) #2
danzh1
On 2016/05/16 21:48:11, Ryan Hamilton wrote: > I don't see crypto_message_printer_bin.cc in this CL? Included ...
4 years, 7 months ago (2016-05-16 22:01:19 UTC) #3
Ryan Hamilton
LGTM. Can you also update the merge instructions to make sure that this new target ...
4 years, 7 months ago (2016-05-16 23:05:55 UTC) #4
danzh1
On 2016/05/16 23:05:55, Ryan Hamilton wrote: > LGTM. Can you also update the merge instructions ...
4 years, 7 months ago (2016-05-16 23:08:51 UTC) #5
Ryan Hamilton
4 years, 7 months ago (2016-05-16 23:19:34 UTC) #6 
On 2016/05/16 23:08:51, danzh1 wrote:
> On 2016/05/16 23:05:55, Ryan Hamilton wrote:
> > LGTM. Can you also update the merge instructions to make sure that this new
> > target is on the list of targets that we build?
> 
> done

Thanks!

Powered by Google App Engine
This is Rietveld 408576698