net/quic/quic_packet_generator.cc - Issue 1983183002: Landing Recent QUIC changes until 5/14/2016 02:25:25 UTC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_packet_generator.cc

Issue 1983183002: Landing Recent QUIC changes until 5/14/2016 02:25:25 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "first try to fix link error for win_clang build" Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_packet_generator.cc

diff --git a/net/quic/quic_packet_generator.cc b/net/quic/quic_packet_generator.cc

index d11383bf636ba87b2453d60fe2bc94b59a391776..c8c927dd5077915aeca5b045e849503f3086edfa 100644

--- a/net/quic/quic_packet_generator.cc

+++ b/net/quic/quic_packet_generator.cc

@@ -59,7 +59,9 @@ QuicConsumedData QuicPacketGenerator::ConsumeData(

QuicStreamOffset offset,

bool fin,

QuicAckListenerInterface* listener) {

- bool has_handshake = id == kCryptoStreamId;

+ bool has_handshake = (id == kCryptoStreamId);

+ QUIC_BUG_IF(has_handshake && fin)

+ << "Handshake packets should never send a fin";

// To make reasoning about crypto frames easier, we don't combine them with

// other retransmittable frames in a single packet.

const bool flush =

« no previous file with comments | « net/quic/quic_headers_stream_test.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »