Issue 1979193011: QUIC_BUG if handshake packets should never send a fin. No functional change intended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1979193011: QUIC_BUG if handshake packets should never send a fin. No functional change intended. (Closed)

Created:
4 years, 7 months ago by danzh1

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, raullenchai_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@121831081

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC_BUG if handshake packets should never send a fin. No functional change intended. Merge internal change: 121840142 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	net/quic/quic_connection_test.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	net/quic/quic_packet_generator.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1982823002 Patch 20001

Dependent Patchsets:

Issue 1986603002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

LGTM Can you remove "REQUIRED_REVIEW=1" from the CL descriptions? (At least in the final CL ...

4 years, 7 months ago (2016-05-16 23:05:11 UTC) #2

danzh1

4 years, 7 months ago (2016-05-17 18:44:27 UTC) #4

On 2016/05/16 23:05:11, Ryan Hamilton wrote:
> LGTM
> 
> Can you remove "REQUIRED_REVIEW=1" from the CL descriptions? (At least in the
> final CL description)

done

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages