[Findit] Filter inline function path frames

[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack, using signature to determine the crash stack, and filter frames before signature while computing main stack. Remove the FilterFramesBeforeSignature function in callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because for these frames, the file paths are not the oringinal file paths.

BUG=611876
Committed: https://chromium.googlesource.com/infra/infra/+/adaf864ffb6be7ae85c71c1cd4adbd3ec677a0e2

[Sharu Jiang, 2016-05-16 22:44:52]

Description was changed from

==========
Filter inline function path frames

BUG=
==========

to

==========
Change GetCrashStack() function of stacktrace to computed property main_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

[Sharu Jiang, 2016-05-16 22:44:52]

katesonia@chromium.org changed reviewers:
+ mbarbella@google.com, stgao@chromium.org

[Sharu Jiang, 2016-05-16 22:46:40]

Description was changed from

==========
Change GetCrashStack() function of stacktrace to computed property main_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

to

==========
Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

[Sharu Jiang, 2016-05-16 22:48:14]

PTAL :)

[Sharu Jiang, 2016-05-16 22:48:40]

Description was changed from

==========
Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

to

==========
[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

[Sharu Jiang, 2016-05-16 22:50:48]

Patchset #1 (id:1) has been deleted

[stgao, 2016-05-17 00:30:35]

lgtm with nits.

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
File appengine/findit/crash/callstack.py (right):

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
appengine/findit/crash/callstack.py:86: super(CallStack,
self).__init__(frame_list)
This seems addressed in the other CL.

You may want to use "git reparent-branch" to make on branch depend on another.

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
File appengine/findit/crash/callstack_filters.py (right):

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
appengine/findit/crash/callstack_filters.py:20: File paths that generated in
runtime are not the oringinal file paths. They
This seems incorrect to me.

The file paths above are not generated in runtime.

[Sharu Jiang, 2016-05-17 18:24:01]

Description was changed from

==========
[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are generated in runtime not the oringinal file
paths.

BUG=611876
==========

to

==========
[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are not the oringinal file paths.

BUG=611876
==========

[Sharu Jiang, 2016-05-17 18:34:59]

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
File appengine/findit/crash/callstack.py (right):

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
appengine/findit/crash/callstack.py:86: super(CallStack,
self).__init__(frame_list)
On 2016/05/17 00:30:34, stgao wrote:
> This seems addressed in the other CL.
> 
> You may want to use "git reparent-branch" to make on branch depend on another.

Since that was committed, I just do a rebase :)

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
File appengine/findit/crash/callstack_filters.py (right):

https://codereview.chromium.org/1980203002/diff/20001/appengine/findit/crash/...
appengine/findit/crash/callstack_filters.py:20: File paths that generated in
runtime are not the oringinal file paths. They
On 2016/05/17 00:30:34, stgao wrote:
> This seems incorrect to me.
> 
> The file paths above are not generated in runtime.

Changed to a safer description.

[Sharu Jiang, 2016-05-17 18:37:59]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2016-05-17 18:38:00]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/1980203002/#ps40001
(title: "Rebase and fix nits.")

[commit-bot: I haz the power, 2016-05-17 18:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980203002/40001

[Martin Barbella, 2016-05-17 18:40:04]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-05-17 18:40:05]

I'm fine with this temporarily, but as discussed during our last meeting I don't
think this approach will actually solve the problem. I suspect there are still
going to be cases where file paths seem wrong due to inlined frames in actual
chromium code.

[commit-bot: I haz the power, 2016-05-17 18:42:08]

Description was changed from

==========
[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are not the oringinal file paths.

BUG=611876
==========

to

==========
[Findit] Filter inline function path frames

Change GetCrashStack() function of stacktrace to computed property crash_stack,
using signature to determine the crash stack, and filter frames before signature
while computing main stack. Remove the FilterFramesBeforeSignature function in
callstack_filters.

Add FilterInlineFunctionFrames to filter those inline function frames, because
for these frames, the file paths are not the oringinal file paths.

BUG=611876

Committed:
https://chromium.googlesource.com/infra/infra/+/adaf864ffb6be7ae85c71c1cd4adb...
==========

[commit-bot: I haz the power, 2016-05-17 18:42:09]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/adaf864ffb6be7ae85c71c1cd4adb...

[Sharu Jiang, 2016-05-17 19:44:42]

On 2016/05/17 18:40:05, Martin Barbella wrote:
> I'm fine with this temporarily, but as discussed during our last meeting I
don't
> think this approach will actually solve the problem. I suspect there are still
> going to be cases where file paths seem wrong due to inlined frames in actual
> chromium code.

I think so, but I cannot think of a good way now, will change this once I found
a better way later.