appengine/findit/crash/test/fracas_parser_test.py - Issue 1980203002: [Findit] Filter inline function path frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/test/fracas_parser_test.py

Issue 1980203002: [Findit] Filter inline function path frames (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase and fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/test/fracas_parser_test.py

diff --git a/appengine/findit/crash/test/fracas_parser_test.py b/appengine/findit/crash/test/fracas_parser_test.py

index 0cebee4005601abfe6dfc79a5cb4c1087d8372ca..9046d43f5649a9d5e0f67eb98003f7750c51b724 100644

--- a/appengine/findit/crash/test/fracas_parser_test.py

+++ b/appengine/findit/crash/test/fracas_parser_test.py

@@ -70,7 +70,7 @@ class FracasParserTest(StacktraceTestSuite):

CRASHED [EXC @ 0x508]

#0 0x8fee in e::f::g(p* &d) src/f.cc:20:2

- #0 0x1fae in h::i::j(p* &d) src/ff.cc:9:1

+ #1 0x1fae in h::i::j(p* &d) src/ff.cc:9:1

"""

)

@@ -84,7 +84,7 @@ class FracasParserTest(StacktraceTestSuite):

expected_callstack1 = CallStack(0)

expected_callstack1.extend(

[StackFrame(0, 'src/', '', 'e::f::g(p* &d)', 'f.cc', [20, 21, 22]),

- StackFrame(0, 'src/', '', 'h::i::j(p* &d)', 'ff.cc', [9, 10])])

+ StackFrame(1, 'src/', '', 'h::i::j(p* &d)', 'ff.cc', [9, 10])])

expected_stacktrace = Stacktrace()

expected_stacktrace.extend([expected_callstack0, expected_callstack1])