[Findit] Filter inline function path frames

appengine/findit/crash/callstack.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from crash import parse_util
 from crash.type_enums import CallStackFormatType
 
 # Used to parse a line into StackFrame of a Callstack.
@@ skipping 60 matching lines @@
       CallStackFormatType.JAVA -
       'at com.android.commands.am.Am.onRun(Am.java:353)'
 
       CallStackFormatType.SYZYASAN -
       'chrome_child!v8::internal::ApplyTransition+0x93 [v8/src/lookup.cc @ 340]'
 
       CallStackFormatType.DEFAULT -
       '#0 0x32b5982 in get third_party/WebKit/Source/wtf/RefPtr.h:61:43'
     language_type (CallStackLanguageType): Either CPP or JAVA language.
   """
-  def __init__(self, stack_priority, format_type=CallStackFormatType.DEFAULT):
-    super(CallStack, self).__init__()
-    self.priority = stack_priority
+  def __init__(self, priority, format_type=CallStackFormatType.DEFAULT,
+               frame_list=None):
+    if frame_list is None:
+      frame_list = []
+
+    super(CallStack, self).__init__(frame_list)

[stgao, 2016/05/17 00:30:34]

This seems addressed in the other CL.

You may want to use "git reparent-branch" to make on branch depend on another.

[Sharu Jiang, 2016/05/17 18:34:58]

Since that was committed, I just do a rebase :)

+    self.priority = priority
     self.format_type = format_type
     self.language_type = parse_util.GetLanguageTypeFromFormatType(format_type)
 
   def ParseLine(self, line, deps):
     """Parse line into StackFrame instance and append it if successfully
     parsed."""
     line = line.strip()
     line_pattern = CALLSTACK_FORMAT_TO_PATTERN[self.format_type]
 
     if self.format_type == CallStackFormatType.JAVA:
@@ skipping 38 matching lines @@
     # If we have the common stack frame index pattern, then use it
     # since it is more reliable.
     index_match = FRAME_INDEX_PATTERN.match(line)
     if index_match:
       stack_frame_index = int(index_match.group(1))
     else:
       stack_frame_index = len(self)
 
     self.append(StackFrame(stack_frame_index, dep_path, component,
                            function, file_path, crashed_line_numbers))