Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: appengine/findit/crash/fracas_parser.py

Issue 1980203002: [Findit] Filter inline function path frames (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase and fix nits. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/findit_for_crash.py ('k') | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/fracas_parser.py
diff --git a/appengine/findit/crash/fracas_parser.py b/appengine/findit/crash/fracas_parser.py
index 51945713cc66003792e65786fbb0dd5b228ebe83..8a0abe2c272f5d19ca627a851666ab9b16e4f9c3 100644
--- a/appengine/findit/crash/fracas_parser.py
+++ b/appengine/findit/crash/fracas_parser.py
@@ -5,7 +5,7 @@
import re
from crash.callstack import CallStack
-from crash.callstack_filters import FilterFramesBeforeSignature
+from crash.callstack_filters import FilterInlineFunctionFrames
from crash.stacktrace import Stacktrace
from crash.stacktrace_parser import StacktraceParser
from crash.type_enums import CallStackFormatType
@@ -21,7 +21,7 @@ class FracasParser(StacktraceParser):
def Parse(self, stacktrace_string, deps, signature=None):
"""Parse fracas stacktrace string into Stacktrace instance."""
- stacktrace = Stacktrace()
+ stacktrace = Stacktrace(signature=signature)
callstack = CallStack(_INFINITY_PRIORITY)
for line in stacktrace_string.splitlines():
@@ -42,7 +42,9 @@ class FracasParser(StacktraceParser):
stacktrace.append(callstack)
# Filter all the frames before signature frame.
- FilterFramesBeforeSignature(stacktrace.GetCrashStack(), signature)
+ if stacktrace:
+ stacktrace = Stacktrace(map(FilterInlineFunctionFrames, stacktrace))
+
return stacktrace
def _IsStartOfNewCallStack(self, line):
« no previous file with comments | « appengine/findit/crash/findit_for_crash.py ('k') | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698