Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: appengine/findit/crash/test/callstack_filters_test.py

Issue 1980203002: [Findit] Filter inline function path frames (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase and fix nits. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/stacktrace.py ('k') | appengine/findit/crash/test/fracas_parser_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/callstack_filters_test.py
diff --git a/appengine/findit/crash/test/callstack_filters_test.py b/appengine/findit/crash/test/callstack_filters_test.py
index 2231acfeedcafcdb06558b1ac7e3da59e18aea9b..31ec6c7b0bf330fdf8c7a19886ab4631a943e931 100644
--- a/appengine/findit/crash/test/callstack_filters_test.py
+++ b/appengine/findit/crash/test/callstack_filters_test.py
@@ -2,8 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import copy
-
from crash.callstack import StackFrame, CallStack
from crash import callstack_filters
from crash.test.stacktrace_test_suite import StacktraceTestSuite
@@ -11,27 +9,26 @@ from crash.test.stacktrace_test_suite import StacktraceTestSuite
class CallStackFiltersTest(StacktraceTestSuite):
- def testEmptyFilterFramesBeforeSignature(self):
- callstack = CallStack(0)
- filtered_callstack = copy.copy(callstack)
- callstack_filters.FilterFramesBeforeSignature(filtered_callstack, '')
-
- self._VerifyTwoCallStacksEqual(callstack, filtered_callstack)
-
- def testFilterFramesBeforeSignature(self):
- callstack = CallStack(0)
- callstack.extend(
- [StackFrame(0, 'src/', '', 'func', 'file0.cc', [32]),
- StackFrame(0, 'src/', '', 'signature_func', 'file1.cc', [53]),
- StackFrame(0, 'src/', '', 'funcc', 'file2.cc', [3])])
-
- filtered_callstack = copy.copy(callstack)
- callstack_filters.FilterFramesBeforeSignature(
- filtered_callstack, 'signature')
-
- expected_callstack = CallStack(0)
- expected_callstack.extend(
- [StackFrame(0, 'src/', '', 'signature_func', 'file1.cc', [53]),
- StackFrame(0, 'src/', '', 'funcc', 'file2.cc', [3])])
+ def testFilterInlineFunctionFrames(self):
+ frame_list = [
+ StackFrame(
+ 0, '', 'src/', 'normal_func', 'f.cc', [2]),
+ StackFrame(
+ 0, '', 'src/', 'inline_func',
+ 'third_party/llvm-build/Release+Asserts/include/c++/v1/a', [1]),
+ StackFrame(
+ 0, '', 'src/', 'inline_func',
+ 'linux/debian_wheezy_amd64-sysroot/usr/include/c++/4.6/bits/b',
+ [1]),
+ StackFrame(
+ 0, '', 'src/', 'inline_func',
+ 'eglibc-3GlaMS/eglibc-2.19/sysdeps/unix/c', [1])
+ ]
+
+ expected_frame_list = frame_list[:1]
+
+ self._VerifyTwoCallStacksEqual(
+ callstack_filters.FilterInlineFunctionFrames(
+ CallStack(0, frame_list=frame_list)),
+ CallStack(0, frame_list=expected_frame_list))
- self._VerifyTwoCallStacksEqual(filtered_callstack, expected_callstack)
« no previous file with comments | « appengine/findit/crash/stacktrace.py ('k') | appengine/findit/crash/test/fracas_parser_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698