Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CFX_WideString(const CFX_WideString&) explicit. BUG= Committed: https://pdfium.googlesource.com/pdfium/+/afe94306e3c542f0d499e7f7706ee5dec4028d8a

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : Override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -232 lines) Patch
M core/fpdfdoc/doc_basic.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M core/fxcrt/fx_basic_bstring.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcrt/fx_basic_buffer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxcrt/include/fx_basic.h View 1 chunk +9 lines, -1 line 0 comments Download
M core/fxcrt/include/fx_string.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_locale.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 6 chunks +6 lines, -9 lines 0 comments Download
M xfa/fgas/localization/fgas_localeimp.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fgas/localization/fgas_localemgr.h View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M xfa/fgas/localization/fgas_localemgr.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_codabar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_code128.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxbarcode/cbc_code39.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_datamatrix.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_ean13.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_ean8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_pdf417i.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_qrcode.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M xfa/fxbarcode/cbc_upca.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCode39Writer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 11 chunks +13 lines, -20 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 20 chunks +20 lines, -20 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/include/fxfa_widget.h View 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/cxfa_validate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_validate.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 6 chunks +14 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 10 chunks +16 lines, -22 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.h View 1 chunk +7 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 13 chunks +18 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-13 23:01:30 UTC) #2
Lei Zhang
Still reading... https://codereview.chromium.org/1979723003/diff/20001/xfa/fgas/localization/fgas_localemgr.h File xfa/fgas/localization/fgas_localemgr.h (right): https://codereview.chromium.org/1979723003/diff/20001/xfa/fgas/localization/fgas_localemgr.h#newcode25 xfa/fgas/localization/fgas_localemgr.h:25: ~CFX_LocaleMgr(); Needs an override as well. That's ...
4 years, 7 months ago (2016-05-13 23:34:48 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1979723003/diff/20001/xfa/fxfa/include/fxfa.h File xfa/fxfa/include/fxfa.h (right): https://codereview.chromium.org/1979723003/diff/20001/xfa/fxfa/include/fxfa.h#newcode549 xfa/fxfa/include/fxfa.h:549: ~IXFA_WidgetIterator() {} Random drive by - virtual as ...
4 years, 7 months ago (2016-05-13 23:37:31 UTC) #4
Tom Sepez
https://codereview.chromium.org/1979723003/diff/20001/xfa/fxfa/include/fxfa.h File xfa/fxfa/include/fxfa.h (right): https://codereview.chromium.org/1979723003/diff/20001/xfa/fxfa/include/fxfa.h#newcode549 xfa/fxfa/include/fxfa.h:549: ~IXFA_WidgetIterator() {} On 2016/05/13 23:37:30, Lei Zhang wrote: > ...
4 years, 7 months ago (2016-05-13 23:45:47 UTC) #5
Tom Sepez
https://codereview.chromium.org/1979723003/diff/20001/xfa/fgas/localization/fgas_localemgr.h File xfa/fgas/localization/fgas_localemgr.h (right): https://codereview.chromium.org/1979723003/diff/20001/xfa/fgas/localization/fgas_localemgr.h#newcode25 xfa/fgas/localization/fgas_localemgr.h:25: ~CFX_LocaleMgr(); On 2016/05/13 23:34:48, Lei Zhang wrote: > Needs ...
4 years, 7 months ago (2016-05-13 23:49:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979723003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979723003/40001
4 years, 7 months ago (2016-05-13 23:49:35 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:21:35 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/afe94306e3c542f0d499e7f7706ee5dec402...

Powered by Google App Engine
This is Rietveld 408576698