xfa/fxfa/parser/xfa_script_imp.cpp - Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_imp.cpp

Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Override Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_script_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_script_imp.cpp b/xfa/fxfa/parser/xfa_script_imp.cpp

index 1cd568904537fb0782fa3f3d0b44f8dba3133e05..893c5b79ea5e145a44188d2e1c3694c09ee81e39 100644

--- a/xfa/fxfa/parser/xfa_script_imp.cpp

+++ b/xfa/fxfa/parser/xfa_script_imp.cpp

@@ -291,7 +291,7 @@ void CXFA_ScriptContext::NormalPropertySetter(FXJSE_HOBJECT hObject,

pPropOrChild = pNode->GetFirstChildByName(wsPropName.AsStringC());

}

if (pPropOrChild) {

- CFX_WideString wsDefaultName = FX_WSTRC(L"{default}");

+ CFX_WideString wsDefaultName(L"{default}");

const XFA_SCRIPTATTRIBUTEINFO* lpAttributeInfo =

XFA_GetScriptAttributeByName(pPropOrChild->GetClassID(),

wsDefaultName.AsStringC());