xfa/fxfa/fm2js/xfa_simpleexpression.cpp - Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/fm2js/xfa_simpleexpression.cpp

Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Override Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/fm2js/xfa_simpleexpression.cpp

diff --git a/xfa/fxfa/fm2js/xfa_simpleexpression.cpp b/xfa/fxfa/fm2js/xfa_simpleexpression.cpp

index aad8f7bed07584c63706bf8ce4fba92fc4b5c9e4..e77623de3a90288e6cfdc7f296325a1b3bfb723a 100644

--- a/xfa/fxfa/fm2js/xfa_simpleexpression.cpp

+++ b/xfa/fxfa/fm2js/xfa_simpleexpression.cpp

@@ -146,7 +146,7 @@ CXFA_FMStringExpression::CXFA_FMStringExpression(uint32_t line,

: CXFA_FMSimpleExpression(line, TOKstring), m_wsString(wsString) {}

void CXFA_FMStringExpression::ToJavaScript(CFX_WideTextBuf& javascript) {

- CFX_WideString tempStr = m_wsString;

+ CFX_WideString tempStr(m_wsString);

if (tempStr.GetLength() > 2) {

javascript.AppendChar(L'\"');

FX_WCHAR oneChar;

@@ -178,7 +178,7 @@ CXFA_FMIdentifierExpressionn::CXFA_FMIdentifierExpressionn(

m_wsIdentifier(wsIdentifier) {}

void CXFA_FMIdentifierExpressionn::ToJavaScript(CFX_WideTextBuf& javascript) {

- CFX_WideString tempStr = m_wsIdentifier;

+ CFX_WideString tempStr(m_wsIdentifier);

if (tempStr == FX_WSTRC(L"$")) {

tempStr = FX_WSTRC(L"this");

} else if (tempStr == FX_WSTRC(L"!")) {

« no previous file with comments | « xfa/fxfa/fm2js/xfa_fmparse.cpp ('k') | xfa/fxfa/include/fxfa.h » ('j') | no next file with comments »