Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: xfa/fgas/localization/fgas_localemgr.h

Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_ 7 #ifndef XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_
8 #define XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_ 8 #define XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_
9 9
10 #include "xfa/fgas/localization/fgas_locale.h" 10 #include "xfa/fgas/localization/fgas_locale.h"
11 11
12 class CFX_LocaleMgr : public IFX_LocaleMgr { 12 class CFX_LocaleMgr : public IFX_LocaleMgr {
13 public: 13 public:
14 CFX_LocaleMgr(uint16_t wDefLCID); 14 CFX_LocaleMgr(uint16_t wDefLCID);
15 virtual void Release() { delete this; } 15
16 virtual uint16_t GetDefLocaleID(); 16 void Release() override { delete this; }
17 virtual IFX_Locale* GetDefLocale(); 17 uint16_t GetDefLocaleID() override;
18 virtual IFX_Locale* GetLocale(uint16_t lcid); 18 IFX_Locale* GetDefLocale() override;
19 virtual IFX_Locale* GetLocaleByName(const CFX_WideStringC& wsLocaleName); 19 IFX_Locale* GetLocale(uint16_t lcid) override;
20 IFX_Locale* GetLocaleByName(const CFX_WideString& wsLocaleName) override;
21
20 CFX_MapPtrToPtr m_lcid2xml; 22 CFX_MapPtrToPtr m_lcid2xml;
21 23
22 protected: 24 protected:
23 ~CFX_LocaleMgr(); 25 ~CFX_LocaleMgr();
Lei Zhang 2016/05/13 23:34:48 Needs an override as well. That's why the compiler
Tom Sepez 2016/05/13 23:49:05 Done.
24 CFX_MapPtrToPtr m_lcid2locale; 26 CFX_MapPtrToPtr m_lcid2locale;
25 uint16_t m_wDefLCID; 27 uint16_t m_wDefLCID;
26 }; 28 };
27 29
28 #endif // XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_ 30 #endif // XFA_FGAS_LOCALIZATION_FGAS_LOCALEMGR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698