xfa/fxfa/fm2js/xfa_expression.cpp - Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/fm2js/xfa_expression.cpp

Issue 1979723003: Make CFX_WideString(const CFX_WideString&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Override Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/fm2js/xfa_expression.cpp

diff --git a/xfa/fxfa/fm2js/xfa_expression.cpp b/xfa/fxfa/fm2js/xfa_expression.cpp

index cecffb9112b8b73919dcb5ea4f6080336df2e410..72020c3f0c7ab2a587ba1b9962e4152e69cee6d0 100644

--- a/xfa/fxfa/fm2js/xfa_expression.cpp

+++ b/xfa/fxfa/fm2js/xfa_expression.cpp

@@ -122,7 +122,7 @@ CXFA_FMVarExpression::CXFA_FMVarExpression(uint32_t line,

void CXFA_FMVarExpression::ToJavaScript(CFX_WideTextBuf& javascript) {

javascript << FX_WSTRC(L"var ");

- CFX_WideString tempName = m_wsName;

+ CFX_WideString tempName(m_wsName);

if (m_wsName.GetAt(0) == L'!') {

tempName = EXCLAMATION_IN_IDENTIFIER + m_wsName.Mid(1);

}

@@ -143,7 +143,7 @@ void CXFA_FMVarExpression::ToJavaScript(CFX_WideTextBuf& javascript) {

void CXFA_FMVarExpression::ToImpliedReturnJS(CFX_WideTextBuf& javascript) {

javascript << FX_WSTRC(L"var ");

- CFX_WideString tempName = m_wsName;

+ CFX_WideString tempName(m_wsName);

if (m_wsName.GetAt(0) == L'!') {

tempName = EXCLAMATION_IN_IDENTIFIER + m_wsName.Mid(1);

}

« no previous file with comments | « xfa/fxfa/app/xfa_textlayout.cpp ('k') | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »