|
Use FileTypePolicies as authoritative source for is_archive and is_supported download classifications.
* Replace all usage of download_protection_util.cc functions except for
GetDownloadType().
* Enable it for Android since it will be used for chrome-controlled
downloads in the future.
* Make FileTypePolicies thread safe via locking. It's created
and updated from several threads (between the ZipAnalyzer sandbox,
SafeBrowsingService, and unit/browser tests). It'll only be accessed
during downloads and incident reports, and will be updated less than
once per few hours.
Coming in following CL:
* Replace all usage of download_extensions.h and FileDangerLevel
BUG= 596555
Committed: https://crrev.com/ac9da06e6e139a110e031dc484757561e9fdeb43
Cr-Commit-Position: refs/heads/master@{#394879}
Total comments: 17
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+205 lines, -759 lines) |
Patch |
|
M |
chrome/browser/BUILD.gn
|
View
|
1
2
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/browser_resources.grd
|
View
|
1
2
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/download/download_danger_prompt.cc
|
View
|
1
2
3
|
2 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/download_protection_service.cc
|
View
|
1
2
3
|
4 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
|
View
|
1
2
3
|
3 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/safe_browsing_service.cc
|
View
|
1
2
3
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/unverified_download_field_trial.cc
|
View
|
1
2
3
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc
|
View
|
1
2
3
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/safe_browsing/unverified_download_policy.cc
|
View
|
1
2
3
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_common.gypi
|
View
|
1
2
|
3 chunks |
+13 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
2
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/common/BUILD.gn
|
View
|
|
1 chunk |
+12 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/download_protection_util.h
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/download_protection_util.cc
|
View
|
1
2
3
|
2 chunks |
+4 lines, -601 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/download_protection_util_unittest.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -49 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/file_type_policies.h
|
View
|
1
2
3
4
|
3 chunks |
+49 lines, -23 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/file_type_policies.cc
|
View
|
1
2
3
|
8 chunks |
+74 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/file_type_policies_unittest.cc
|
View
|
|
8 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/common/safe_browsing/zip_analyzer.cc
|
View
|
1
2
3
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
Total messages: 18 (8 generated)
|