chrome/browser/safe_browsing/unverified_download_field_trial.cc - Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/unverified_download_field_trial.cc

Issue 1979153002: Use FileTypePolicies for is_archive and is_supported classifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_by_platform

Patch Set: Fix comment, per asanka's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | chrome/browser/safe_browsing/unverified_download_field_trial_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/unverified_download_field_trial.cc

diff --git a/chrome/browser/safe_browsing/unverified_download_field_trial.cc b/chrome/browser/safe_browsing/unverified_download_field_trial.cc

index bc3fb4126594c8260b9d1b130ae9cf3e6bb8ed6a..530b5cb81aef9477c4fb8801f22f49f23ee34d73 100644

--- a/chrome/browser/safe_browsing/unverified_download_field_trial.cc

+++ b/chrome/browser/safe_browsing/unverified_download_field_trial.cc

@@ -12,7 +12,7 @@

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/safe_browsing/download_protection_util.h"

+#include "chrome/common/safe_browsing/file_type_policies.h"

#include "components/variations/variations_associated_data.h"

namespace safe_browsing {

@@ -70,7 +70,7 @@ bool IsUnverifiedDownloadAllowedByFieldTrial(const base::FilePath& file) {

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisallowUncheckedDangerousDownloads) &&

- download_protection_util::IsSupportedBinaryFile(file))

+ FileTypePolicies::GetInstance()->IsCheckedBinaryFile(file))

return false;

if (base::StartsWith(group_name,

@@ -92,7 +92,7 @@ bool IsUnverifiedDownloadAllowedByFieldTrial(const base::FilePath& file) {

if (parameters.count(kUnverifiedDownloadFieldTrialBlockSBTypesParam) &&

!parameters[kUnverifiedDownloadFieldTrialBlockSBTypesParam].empty() &&

- download_protection_util::IsSupportedBinaryFile(file))

+ FileTypePolicies::GetInstance()->IsCheckedBinaryFile(file))

return false;

}